Simplify the report processor #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
force-pushed
the
simplify-report-processor
branch
from
daf7a6a
to
515a66f
Compare
ekohl
commented
Oct 28, 2022
ekohl
force-pushed
the
simplify-report-processor
branch
from
515a66f
to
de30b20
Compare
ekohl
commented
Oct 25, 2024
Rather than defining an entry and then appending it, this writes it all out so it's clear what the structure is.
Even Puppet 2.6 uses format version 2.
This takes advantage of the fact that each title is the same as the metric's name.
This saves an intermediate array.
ekohl
force-pushed
the
simplify-report-processor
branch
from
de30b20
to
5ff7a96
Compare
ehelms
approved these changes
Oct 25, 2024
bastelfreak
approved these changes
Oct 25, 2024
|
We're now in the stabilization week of Foreman 3.13 so I'm going to hold off on merging this until after. |
|
@ekohl ready to merge this? |
|
We're getting ready for merging Rails 7 and I'd prefer to avoid additional instability. We haven't had Foreman nightly in a week or so, so let's first get that stable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops a lot of old legacy code that was used in the Puppet < 2.6 days. Those days are far behind us and this simplifies the processor a lot. It still doesn't take advantage of fields added in "recent" versions.